This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: jni.h: Define JNICALL, JNIIMPORT and JNIEXPORT for Win32


Ranjit Mathew <rmathew@hotmail.com> writes:
>      The following trivial patch updates the JNI linker
> defines for Win32 in jni.h.

Looks good to me; I'll commit it tomorrow.


> Another thing to note is the use of _WIN32, __WIN32__ and
> WIN32 - _WIN32 is the MS specified Win32 define, some
> compilers define __WIN32__ and libgcj itself uses WIN32.
> I didn't know which one to favour over the others... :-)

For now, use WIN32 for consistency.  At some point we can change all
the ifdefs in one big patch.

  - a



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]