This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] jar tool should honour umask while creating a jar
- From: Tom Tromey <tromey at redhat dot com>
- To: Ranjit Mathew <rmathew at hotmail dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: 17 Oct 2002 08:29:33 -0600
- Subject: Re: [PATCH] jar tool should honour umask while creating a jar
- References: <aolni1$lf9$1@main.gmane.org>
- Reply-to: tromey at redhat dot com
>>>>> "Ranjit" == Ranjit Mathew <rmathew@hotmail.com> writes:
Ranjit> I noticed that the jar tool with GCJ does not honour umask
Ranjit> settings while creating a jar, while the jar tool included
Ranjit> with Sun's JDK does. Now I don't have any specs to back this
Ranjit> up, but I feel that the jar tool *should* honour the umask
Ranjit> settings for the user running the tool.
I agree.
Ranjit> If you guys agree with me, you should consider applying
Ranjit> the following patch to "fastjar/jartool.c":
Ranjit> - jarfd = open(jarfile, O_CREAT | O_BINARY | O_WRONLY | O_TRUNC,
Ranjit> - S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
Ranjit> + jarfd = open(jarfile, O_CREAT | O_BINARY | O_WRONLY | O_TRUNC);
Let's add the missing bits instead.
Or perhaps just use `0777'.
Tom