This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: java.net: TCP sockets
- From: Tom Tromey <tromey at redhat dot com>
- To: Michael Koch <konqueror at gmx dot de>
- Cc: java-patches at gcc dot gnu dot org
- Date: 06 Sep 2002 11:00:14 -0600
- Subject: Re: java.net: TCP sockets
- References: <E17n1bL-0006Sr-00@majestix.konqueror.de>
- Reply-to: tromey at redhat dot com
>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:
Michael> If there are portability issues I would like to fix them
Michael> after commit as they are reported.
I think the use of poll.h will be a problem.
Could you use _Jv_select here instead?
Some nits follow.
+ // sending urgend data.
Typo; should be 'urgent'.
+ protected native void connect (SocketAddress addr, int timeout) throws IOException;
This line probably needs to be wrapped before the `throws'.
Except in special situations, lines shouldn't be longer than 79 chars.
+java::net::PlainSocketImpl::connect (java::net::SocketAddress *addr, jint timeout)
Likewise, wrap before `jint'.
Tom