This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: java.net patch
- From: Tom Tromey <tromey at redhat dot com>
- To: Michael Koch <konqueror at gmx dot de>
- Cc: java-patches at gcc dot gnu dot org
- Date: 04 Sep 2002 11:14:40 -0600
- Subject: Re: java.net patch
- References: <E17mdAb-0004sJ-00@majestix.konqueror.de>
- Reply-to: tromey at redhat dot com
>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:
Michael> Please review this patch.
+ if (tc < 0 || tc > 255) throw new IllegalArgumentException();
The `throw' needs to go on its own line.
+ throw new java::lang::InternalError (
+ JvNewStringUTF ("SO_BROADCAST not valid for TCP"));
In other places we throw SocketException for this sort of thing.
Which do you think is more correct? (Or, what does Sun do?)
I think we should at least be internally consistent here.
+ return new java::lang::Boolean ((__java_boolean)val);
Use `jboolean', not `__java_boolean'.
Other than these the patch looks fine. Please check it in once these
are fixed. Thanks!
Tom