This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Updated throwable and stacktrace printing patch
- From: Mark Wielaard <mark at klomp dot org>
- To: java-patches at gcc dot gnu dot org
- Date: 15 Aug 2002 22:28:11 +0200
- Subject: Re: Updated throwable and stacktrace printing patch
- References: <1029186294.14859.33.camel@elsschot>
Hi,
> 2002-08-12 Mark Wielaard <mark@klomp.org>
>
> * Makefile.am (libgcj_la_SOURCES): Remove name-finder.cc.
> (core_java_source_files): Add VMThrowable.java and NameFinder.java
> (nat_source_files): Remove natThrowable.cc, add natVMThrowable.cc
> and natNameFinder.cc.
> * Makefile.in: Regenerate.
> * prims.cc: Use trace_enabled from VMThrowable.
> * name-finder.cc: Removed.
> * gcj/javaprims.h: Add class VMThrowable.
> * gnu/gcj/runtime/NameFinder.java: New file.
> * gnu/gcj/runtime/natNameFinder.cc: Likewise.
> * include/name-finder.h: Removed.
> * java/lang/Throwable.java (printStackTrace (PrintStream)): Use new
> method stackTraceString().
> (printStackTrace (PrintWriter)): Likewise.
> (stackTraceString): Complete rewrite of old printStackTrace using
> StringBuffer.
> (stackTraceStringBuffer): New helper method for stackTraceString().
> (fillInStackTrace): Delegate to VMTrowable.
> (getStackTrace): Likewise.
> (getStackTrace0): Removed.
> (trace_enabled, stackTraceBytes): Moved to new VMThrowable.java.
> * java/lang/natThrowable.cc: Removed (replaced by natVMThrowable).
> * java/lang/VMThrowable.java: New class.
> * java/lang/natVMThrowable.cc: New file.
>
> Tested on i686-pc-linux-gnu and currently building and testing on
> powerpc-unknown-linux-gnu. OK to commit if build and tests are
> successful?
My tests on powerpc were successful.
Could someone please review it?
I think the patch addresses all issues that were raised last time.
How does the code freeze for 3.3 (that starts today) impact runtime
library patches such as this one?
Cheers,
Mark