This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH]: adds missing System properties for gcj under mingw

From: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>
To: Adam King <aking at dreammechanics dot com>
Cc: java-patches at gcc dot gnu dot org, adam at xwt dot org
Date: Sun, 07 Apr 2002 23:26:18 +1200
Subject: Re: [PATCH]: adds missing System properties for gcj under mingw
References: <20020406004521.B27004@dreammechanics.com> <3CAE9381.50803@waitaki.otago.ac.nz> <20020407015733.B13256@dreammechanics.com>

Adam King wrote:

>I've done as you suggested and created a new method
>_Jv_platform_initProperties() which now sets the platform specific 
>System properties when called from init_properties.  I also
>saw another '#ifdef WIN32' in init_properties which I moved into
>the new method. I'm still learning - so please let me know if there's
>any other changes I need to make.
>

This looks fine. Please note that comments and ChangeLog entries are 
supposed to be written as full sentences, ie starting with a capital 
letter etc. I will fix those up and check in the patch.

Thanks!

Bryce.

References:
- [PATCH]: adds missing System properties for gcj under mingw
  - From: aking
- Re: [PATCH]: adds missing System properties for gcj under mingw
  - From: Bryce McKinlay
- Re: [PATCH]: adds missing System properties for gcj under mingw
  - From: Adam King

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]