This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: PATCH: remove all traces of java.io.FileDescriptor from java.net
- From: Tom Tromey <tromey at redhat dot com>
- To: Jeff Sturm <jsturm at one-point dot com>
- Cc: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>, java-patches at gcc dot gnu dot org
- Date: 26 Mar 2002 16:06:52 -0700
- Subject: Re: PATCH: remove all traces of java.io.FileDescriptor from java.net
- References: <Pine.LNX.4.10.10203261147510.3710-100000@mars.deadcafe.org>
- Reply-to: tromey at redhat dot com
>>>>> "Jeff" == Jeff Sturm <jsturm@one-point.com> writes:
>> Is the idea that the SocketImpl.getFileDescriptor would just return
>> null?
Jeff> getFileDescriptor() returns `fd'. If we don't initialize `fd' in
Jeff> PlainSocketImpl then yes, it will return null.
We need a comment somewhere indicating that we purposely don't
initialize `fd', and why. Otherwise in a couple years someone will
notice and try to put it back.
Could you add such a comment? Maybe the best place is in the
constructors where, before your patch, we used to create the
FileDescriptor.
Jeff> We don't really have a good testsuite for java.net, but our
Jeff> application does exercise java.net.Socket considerably and it
Jeff> seems to work fine:
There are some tests in Mauve, but I don't know their current status.
Jeff> 2002-03-26 Jeff Sturm <jsturm@one-point.com>
Jeff> [ ... ]
Please check this in. Thanks.
Tom