This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: PR 5942
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- To: tromey at redhat dot com
- Cc: apbianco at redhat dot com, gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- Date: Tue, 26 Mar 2002 14:05:15 -0500 (EST)
- Subject: Re: Patch: PR 5942
> From: Tom Tromey <tromey@redhat.com>
>
> * parse.y (init_src_parse): Added sanity check.
>
> + /* Sanity check; we've been bit by this before. */
> + if (sizeof (ctxp->modifier_ctx) / sizeof (tree) !=
> + MODIFIER_TK - PUBLIC_TK)
Please consider using ARRAY_SIZE(ctxp->modifier_ctx) (defined in
libiberty.h) instead of an explicit sizeof() / sizeof().
IMHO, ARRAY_SIZE is much more readable.
Thanks,
--Kaveh
--
Kaveh R. Ghazi Director of Systems Architecture
ghazi@caip.rutgers.edu Qwest Global Services