This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: gcj ggc patch
- From: Per Bothner <per at bothner dot com>
- To: tromey at redhat dot com
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>, Java Patch List <java-patches at gcc dot gnu dot org>
- Date: Wed, 06 Mar 2002 14:41:42 -0800
- Subject: Re: Patch: gcj ggc patch
- References: <87r8mx48kg.fsf@creche.redhat.com>
Tom Tromey wrote:
> I don't really know whether this patch is necessary. I found other
> occurrences of ggc_add_tree_root in similar situations in jcf-write.c.
> And as far as I can tell these static variables weren't otherwise
> marked as roots.
>
> Is this required? If so, is it ok to commit?
From what I can tell: No, and no.
init_stringpool (in stringpool.c) marks the entire stringpool
hash table,
But it would be good to get an authoritative ruling:
Does an identifier node stashed in a global variable need
to be explicitly ggc-registerd?
--
--Per Bothner
per@bothner.com http://www.bothner.com/per/