This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: java.lang.Character
Tom Tromey wrote:
>>>>>>"Eric" == Eric Blake <ebb9@email.byu.edu> writes:
>>>>>>
>
>Eric> Tom, do I have permission to check in my changes to Character?
>Eric> http://gcc.gnu.org/ml/java-patches/2002-q1/msg00451.html
>
>I finally had a chance to look at this.
>Could you update it a little bit to remove scripts/blocks.pl?
>You don't have to resubmit or repost the patch -- just remove the file
>and add a ChangeLog entry for it. This script is obsoleted by your
>patch.
>
>Anyway, this patch looks great to me. Please do check it in.
>Can you also check it in on the 3.1 branch? I think we might as well
>do that too.
>
One thing that might be improved is to have the getType() method in
native code. Currently a lot of the methods in the Java code call
getType() which then calls the native readChar() - it would reduce the
number of calls to have getType() native as well?
Also could some of the other tables like BLOCKS be done as C arrays also?
I agree the patch is fine to go in as it is - its certainly an
improvement over what we have currently and we can always optimize it
further later.
thanks
Bryce.