This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Java patch] AM_ICONV fix

From: Tom Tromey <tromey at redhat dot com>
To: Craig Rodrigues <rodrigc at mediaone dot net>
Cc: java-patches at gcc dot gnu dot org
Date: 01 Feb 2002 13:56:29 -0700
Subject: Re: [Java patch] AM_ICONV fix
References: <20020127182702.A2463@mediaone.net> <orbsffuxfq.fsf@free.redhat.lsd.ic.unicamp.br> <20020127195743.A4106@mediaone.net>
Reply-to: tromey at redhat dot com

>>>>> "Craig" == Craig Rodrigues <rodrigc@mediaone.net> writes:

Craig> OK.  For whoever as approval privileges on libjava, is this OK?

Craig> 2002-01-27  Craig Rodrigues  <rodrigc@gcc.gnu.org>
Craig>         PR java/4972
Craig>         * aclocal.m4, acinclude.m4 (AM_ICONV): Put linking flags 
Craig> 	for libiconv in LIBICONV variable.
Craig>         * configure: Regenerated

This is fine, thanks.

Craig>        if test -d $dir/include; then CPPFLAGS="$CPPFLAGS -I$dir/include"; fi

If we want this to end up in the Makefile then we should probably add
the -I to LIBGCJ_CXXFLAGS and not CPPFLAGS.  CPPFLAGS is a user
variable.  I'm not super concerned about this though.

Tom

References:
- [Java patch] AM_ICONV fix
  - From: Craig Rodrigues
- Re: [Java patch] AM_ICONV fix
  - From: Alexandre Oliva
- Re: [Java patch] AM_ICONV fix
  - From: Craig Rodrigues

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]