Re: PATCH: interpreter.cc bug patch and performance improvements (plus attachments)

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Chris" == Chris Sears <cbsears_sf@yahoo.com> writes:

Chris> my last email to you bounced, too many hops.

Mail here was down for a day :-(

Chris> Attached is an expanded and more documented patch.  I think
Chris> I've handled the SEGV case correctly.

I agree.

Chris> In addition, I've changed the SAVE_PC macro to save pc rather
Chris> than pc-1 and the exception handler to compute offset by one.

Sounds good.

Chris> Also, fdiv, frem, ddiv and drem can't cause runtime exceptions,
Chris> so they don't need SAVE_PC's.

Thanks, this makes sense too.

I'll be checking in your patch shortly.  If you plan to submit future
patches, you'll need paperwork filled out before we'll be able to
check them in.  I can get you started on this process if you like.

Also, in the future please write a complete ChangeLog entry for your
patches.  I can point you to documentation on how to do this if you
need it.

Thanks,
Tom