This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: socket timeout patch: formatting changes
- From: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>
- To: Nic Ferrier <nferrier at tf1 dot tapsellferrier dot co dot uk>
- Cc: java-patches at gcc dot gnu dot org
- Date: Thu, 13 Dec 2001 13:01:27 +1300
- Subject: Re: socket timeout patch: formatting changes
- References: <E16EHgU-0000Rh-00@tf1.tapsellferrier.co.uk>
Nic Ferrier wrote:
>Here's a small formatting change diff for the class
>PlainSocketImpl.java.
>
>It would really help me if this was applied to the CVS (I can more
>easily merge my real changes).
>
>
>Note: I've not paid much attention to line breaks, the rest of the
>code doesn't seem to. Are line breaks *such* an issue these days?
>
>
>- public native void setOption(int optID, Object value) throws SocketException;
>+ public native void setOption (int optID, Object value) throws SocketException;
>
In general we don't follow the space-before-method-call-bracket
convention for Java code. I know that there is still code in both
libgcj/classpath which does, but newer source (eg all of java.util)
typically doesn't.
Like Tom I don't mind reformatting as long as its kept separate from
code changes, but shouldn't this change be going the other way?
regards
Bryce.