This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
socket timeout patch
- From: Andrew Haley <aph at cambridge dot redhat dot com>
- To: "Nic Ferrier" <nferrier at tapsellferrier dot co dot uk>
- Cc: <java-patches at gcc dot gnu dot org>
- Date: Thu, 13 Dec 2001 02:23:29 +0000 (GMT)
- Subject: socket timeout patch
- References: <00c601c18338$2f545df0$0e07a8c0@internal.mondus.com>
Nic Ferrier writes:
> The attached patch provides connection timeouts for java sockets.
>
> It's vital for paperclips (the GNU servlet engine) as well (I imagine) for
> any other HTTP implementation in java.
>
>
> The attached file contains some formatting changes over the original... I
> know the policy is not to accept such changes. Can someone confirm if the
> changes enclosed are acceptable, if not I would like to provide 2 patches,
> the first 2 correct the coding style of the existing files and the second to
> provide the fix.
Formatting patches must always be submitted separately.
In any case, there is a lot of broken formatting here.
This, for example:
- if (host != NULL)
- memcpy (&u.address.sin_addr, bytes, len);
+ if(host != NULL)
+ memcpy(&u.address.sin_addr, bytes, len);
and this:
- struct sockaddr *ptr = (struct sockaddr *) &u.address;
- if (len == 4)
+ struct sockaddr *ptr =(struct sockaddr *) &u.address;
+ if(len == 4)
some lines are too long:
- throw new java::io::IOException (
- JvNewStringLatin1 ("SocketImpl.create: unimplemented"));
+ throw new java::io::IOException(JvNewStringLatin1("SocketImpl.create: unimplemented"));
Please refer to http://www.gnu.org/prep/standards_toc.html.
Andrew.