This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: Another BigInteger bug.

To: Per Bothner <per at bothner dot com>
Subject: Re: Another BigInteger bug.
From: Tom Tromey <tromey at redhat dot com>
Date: 17 Aug 2001 11:40:31 -0600
Cc: "Boehm, Hans" <hans_boehm at hp dot com>, "'java-patches at gcc dot gnu dot org'" <java-patches at gcc dot gnu dot org>
References: <140D21516EC2D3119EE7009027876644049B5FD9@hplex1.hpl.hp.com> <3B7C59DD.7060003@bothner.com>
Reply-To: tromey at redhat dot com

Hans> Right shifts of negative numbers by nonzero multiples of 32
Hans> generally produced the wrong answer.  This seems to be yet
Hans> another case where the code assumed that left shifting an int by
Hans> 32 produced 0.

Per> Oops.  How about the following instead, which avoids the extra test:

Thanks guys.

Could one of you review this BigInteger patch?

    http://gcc.gnu.org/ml/java/2001-08/msg00058.html

I haven't done anything with BigInteger, so I'm reluctant to approve
or reject it.

Tom

References:
- Another BigInteger bug.
  - From: Boehm, Hans
- Re: Another BigInteger bug.
  - From: Per Bothner

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]