This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: patches to re-direct _Jv_RegisterClass


>>>>> "Per" == Per Bothner <per@bothner.com> writes:

Per> This patch allows _Jv_RegisterClass to be bypassed using a "hook
Per> function".

I think there should be a comment by _Jv_RegisterClassHook explaining
that you must acquire the Class mutex before changing it.  This might
not be necessary, since it might be the case that no existing or
future system can dlopen and invoke static constructors on two shared
libraries at once.  However, it is safe and easy.

Per> It might be useful to include SharedLibLoader in libgcj, if
Per> people think that would be desirable.

How does it differ from the shared library code already in the default
classloader?

Per> +void _Jv_RegisterClassHookDefault (jclass klass)

The `void' should appear on its own line.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]