This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: preliminary invocation patch


Tom Tromey <tromey@redhat.com> writes:

> We could have StringBuffer.append(int) call a method elsewhere that
> expects a buffer and offset argument.  For instance it could call a
> package-private method on String or Integer.  This method could have
> different implementations in Classpath and libgcj.

That looses for Integer.toString() and String.valueOf(int), because
it forces allocation of a char[], which is then discarded.

I've implemented _Jv_FormatInt, and code to use it various places.
I'll try to post a patch today or tomorrow.

> The more we have synchronized, the easier maintenance becomes.  That's
> because we can merge in either direction with fewer special cases.  So
> I think the default should be to synchronize.

In principle yes, but I don't think we're like to do much
synchronization of core classes in java.lang.  At most occasional
bug-fixes.
-- 
	--Per Bothner
per@bothner.com   http://www.bothner.com/per/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]