This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Missing call to iconv_close.
- To: java-patches at gcc dot gnu dot org
- Subject: Re: Missing call to iconv_close.
- From: Mo DeJong <mdejong at cygnus dot com>
- Date: Thu, 3 May 2001 23:14:04 -0700 (PDT)
On 3 May 2001, Tom Tromey wrote:
> >>>>> "Mo" == Mo DeJong <mdejong@cygnus.com> writes:
>
> Mo> Here is a quick patch that closes an iconv handle
> Mo> that seems to have been left open in gcc/java/lex.c.
>
> Wow, good catch. Did you find this by reading the code, or was there
> an actual failure?
I was just stealing the idea of a second call to iconv
to figure out if the bytes needed a swap for Jikes
when I noticed the problem.
> I CC'd gcc-patches -- front-end patches have to go there as well.
I will try to remember that in the future.
Mo