This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Java: Fix cyclic inheritance detection problem
- To: Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>
- Subject: Re: Java: Fix cyclic inheritance detection problem
- From: Alexandre Petit-Bianco <apbianco at cygnus dot com>
- Date: Fri, 27 Apr 2001 11:32:45 -0700 (PDT)
- Cc: java-patches at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- References: <3AE95D88.A2350982@waitaki.otago.ac.nz>
- Reply-To: apbianco at cygnus dot com
Bryce McKinlay writes:
> Although GCJ has a mechanism to detect cyclic inheritance, it isn't
> working in most cases. Possibly this was broken with the multifile
> compilation changes, or maybe it was broken even before that.
I'm pretty sure it used to work 2/3 years ago :-) But I never took the
time to write a test to catch for that particular regressions, and
tons of others for that matter.
> Actually, its not clear to me why resolve_class() is called with an
> "enclosing" argument at all here, because X is not an inner class
Indeed. This was required for some reason but I can't remember why --
maybe static inner classes. Anyways, I'm making a note to look into
this issue.
> ok to commit?
It looks fine, but let me run some more tests, and I haven't finished
testing Per's yesterday patch. Stay tuned, thanks.
./A