This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch to use concat instead of xmalloc/sprintf for JAVA dir
- To: tromey at redhat dot com
- Subject: Re: Patch to use concat instead of xmalloc/sprintf for JAVA dir
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Mon, 23 Apr 2001 16:08:54 -0400 (EDT)
- Cc: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org, per at bothner dot com
> From: Tom Tromey <tromey@redhat.com>
>
> >>>>> "Kaveh" == Kaveh R Ghazi <ghazi@caip.rutgers.edu> writes:
>
> >> > 2001-04-19 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
> >> > * jvspec.c (lang_specific_driver): Fix memory allocation
> >> > deficit, by using concat in lieu of xmalloc/sprintf.
>
> Kaveh> PS: Should I also apply the patch to the branch?
>
> Doesn't it qualify as an obvious bug fix? We know the existing code
> is broken due to a buffer overrun. So it seems to me that something
> must be checked in.
> Tom
Yes, but in my original posting I asked whether the concat change was
okay for the branch, or should I simply bump the original xmalloc
count by one which could be construed as safer.
I think the concat is "obvious", but the last time I checked in an
obvious concat change to java a few weeks ago, it broke. I'm just
being careful and asking for explicit guidance this time. :-)
--Kaveh
--
Kaveh R. Ghazi Engagement Manager / Project Services
ghazi@caip.rutgers.edu Qwest Internet Solutions