This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch to use concat instead of xmalloc/sprintf for JAVA dir
- To: per at bothner dot com
- Subject: Re: Patch to use concat instead of xmalloc/sprintf for JAVA dir
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Sun, 22 Apr 2001 20:27:15 -0400 (EDT)
- Cc: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
> From: Per Bothner <per@bothner.com>
>
> "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:
>
> > 2001-04-19 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
> >
> > * jvspec.c (lang_specific_driver): Fix memory allocation
> > deficit, by using concat in lieu of xmalloc/sprintf.
>
> > Bootstrapped on solaris2.7, no regressions. Ok to install?
>
> You have my blessing. One detail: I notice gcc.c uses NULL_PTR
> rather than NULL for the terminating argument to concat. I don't
> know which style is preferred.
Regarding NULL vs NULL_PTR, there is some inconsistency as both styles
are currently used in calls to concat. However NULL_PTR is deprecated
according to comments in ansidecl.h where it is defined, so I used
NULL.
--Kaveh
PS: Should I also apply the patch to the branch?
--
Kaveh R. Ghazi Engagement Manager / Project Services
ghazi@caip.rutgers.edu Qwest Internet Solutions