This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch to use concat instead of xmalloc/sprintf for JAVA dir


 > From: Per Bothner <per@bothner.com>
 > 
 > "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu> writes:
 > 
 > > 2001-04-19  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
 > > 
 > > 	* jvspec.c (lang_specific_driver): Fix memory allocation
 > > 	deficit, by using concat in lieu of xmalloc/sprintf.
 > 
 > > Bootstrapped on solaris2.7, no regressions.  Ok to install?
 > 
 > You have my blessing.  One detail:  I notice gcc.c uses NULL_PTR
 > rather than NULL for the terminating argument to concat.  I don't
 > know which style is preferred.

Regarding NULL vs NULL_PTR, there is some inconsistency as both styles
are currently used in calls to concat.  However NULL_PTR is deprecated
according to comments in ansidecl.h where it is defined, so I used
NULL.

		--Kaveh

PS: Should I also apply the patch to the branch?

--
Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Qwest Internet Solutions


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]