This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: libffi patch for IA-64
- To: Jim Wilson <wilson at cygnus dot com>
- Subject: Re: libffi patch for IA-64
- From: Tom Tromey <tromey at redhat dot com>
- Date: 18 Apr 2001 15:01:32 -0600
- Cc: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- References: <200104182039.NAA15898@wilson.cygnus.com>
- Reply-To: tromey at redhat dot com
>>>>> "Jim" == Jim Wilson <wilson@cygnus.com> writes:
Jim> I would have run the testsuite, but I couldn't find one. make
Jim> check doesn't do anything useful in the libffi and libjava
Jim> directories. Also make check-java doesn't do anything useful in
Jim> the gcc directory.
`check' in the libjava directory ought to do something.
I regularly use `make check-target-libjava'.
Having `check-java' do something in the gcc directory would be a pain.
That's because the Java compiler relies on the presence of certain
classes to do anything at all. Instead of fight with this, we chose
to put all the tests into libjava.
I doubt that libffi is tested much by the libjava test suite. So not
running that is ok.
ffi has a `ffitest' program which is always built. However, the
libffi check target does not invoke it. This is a bug in the libffi
Makefile (imho). This program might or might not test the code you
modified. I'm not certain, and I haven't looked at it in depth.
Jim> The patch has been added to both the trunk and branch, since the
Jim> same problem is present in both places.
Thanks for doing this!
Tom