This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Old patch for DataInpuStream from Classpath


Hi,

On Fri, Jan 26, 2001 at 11:04:03AM +1300, Bryce McKinlay wrote:
> Warren Levy wrote:
> > On Thu, 25 Jan 2001, Mark Wielaard wrote:
> >
> > > The following patch was made last month to the Classpath version of
> > > java.io.InputStream but was not applied to the libgcj version.
> > > OK to commit?
> > >
> > > 2000-12-09  Bryce McKinlay  <bryce@albatross.co.nz>
> > >
> > >     * java/io/DataInputStream.java (readBoolean): Use convertToBoolean().
> > ...
> >
> > Looks fine to me; I've cc'ed Bryce in case he had a reason to not put it
> > in libgcj.
> 
> There's probibly no reason why the classpath version can't go into libgcj,
> except that its a little more complicated and possibly less efficient. Long
> term, the best solution is a cleanup/merge of all the
> File/FileDescriptor/RandomAccessFile related stuff...

OK. I am going to check in the Classpath version then.
I am trying to make an overview of the merge status of Classpath and libgcj
and I am trying to minimize the number of small differences.

Cheers,

Mark
-- 
Stuff to read:
    <http://www.toad.com/gnu/whatswrong.html>
  What's Wrong with Copy Protection, by John Gilmore


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]