This is the mail archive of the
java-patches@sources.redhat.com
mailing list for the Java project.
Re: Patch: String.unintern
- To: tromey at redhat dot com
- Subject: Re: Patch: String.unintern
- From: Bryce McKinlay <bryce at albatross dot co dot nz>
- Date: Thu, 25 Jan 2001 13:33:53 +1300
- CC: Java Patch List <java-patches at sourceware dot cygnus dot com>
- References: <87wvbl62tw.fsf@creche.redhat.com>
Tom Tromey wrote:
> I've written a patch that, I think, makes uninterning of Strings work.
>
> Last time we talked about this it turned out there were some ways to
> make libgcj crash if uninterning was enabled. Does anybody have a
> test program that used to do this? I can't make it happen, but that
> doesn't mean this patch is correct...
InternHog.java from Kaffe is one test. With you're patch, it is currently failing
after 12179 iterations in rehash().
> I don't want to check it in until someone else looks at it.
>
> The patch is a bit ugly. Any suggestions?
It's nowhere near as ugly as some of the solutions I was contemplating last time
I looked at this!
regards
[ bryce ]