This is the mail archive of the
java-patches@sources.redhat.com
mailing list for the Java project.
Re: PATCH: Minor signature fixes
- To: Tom Tromey <tromey at redhat dot com>
- Subject: Re: PATCH: Minor signature fixes
- From: Warren Levy <warrenl at cygnus dot com>
- Date: Sun, 3 Dec 2000 20:32:19 -0800 (PST)
- cc: Bryce McKinlay <bryce at albatross dot co dot nz>, Java Patch List <java-patches at sourceware dot cygnus dot com>
On 3 Dec 2000, Tom Tromey wrote:
> Warren> Take a look at the JCL 1.2 supplement and the online doc to
> Warren> see what I mean. There are even some cases where I change the
> Warren> order of things (e.g. the order of exceptions in a throws
> Warren> clause or the interfaces in an implements clause) to reduce
> Warren> the noise even though they are not strictly a problem.
>
> We should fix the comparison script so that meaningless divergences
> are simply not reported. Reordering exceptions like that seems
> pointless.
Well, it hadn't been an issue before this last merge with Classpath (i.e.
I don't recall it ever happening before). And in this case I only saw it
in 2 instances. We certainly can change the script; it was just easier
for me under the circumstances to change the classes. Changing the script
would entail adding parsing so it could tell meaningless divergences from
significant ones.
--warrenl