This is the mail archive of the
java-patches@sources.redhat.com
mailing list for the Java project.
Re: [PATCH] java.util.zip code updates
- To: Mark Wielaard <mark at klomp dot org>
- Subject: Re: [PATCH] java.util.zip code updates
- From: Tom Tromey <tromey at cygnus dot com>
- Date: 15 Nov 2000 21:17:44 -0700
- Cc: java-patches at sources dot redhat dot com
- References: <20001116014043.A18944@klomp.org>
- Reply-To: tromey at cygnus dot com
>>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:
Mark> OK to commit?
Mark> - c = crc_table[(c ^ bval) & 0xff] ^ (c >>> 8);
Mark> + c = crc_table[(c ^ (bval & 0xff)) & 0xff] ^ (c >>> 8);
When can this change matter?
Mark> + public int available() {
This brace should be on the next line.
Other than that, this patch is ok.
Tom