This is the mail archive of the
java-patches@sources.redhat.com
mailing list for the Java project.
Re: Patch: Fix last patch and convert throws
- To: Bryce McKinlay <bryce at albatross dot co dot nz>
- Subject: Re: Patch: Fix last patch and convert throws
- From: Tom Tromey <tromey at cygnus dot com>
- Date: 05 Sep 2000 16:06:23 -0600
- Cc: java-patches at sourceware dot cygnus dot com
- References: <39B56C5C.F610BD11@albatross.co.nz>
- Reply-To: tromey at cygnus dot com
Bryce> This patch fixes the error in my last patch, and also converts
Bryce> all the JvThrow() calls in java.net to throw statements, for
Bryce> consistency.
Bryce> - if (::setsockopt (fnum, level, opname, ptr, len) == 0)
Bryce> + if (::setsockopt (fnum, level, opname, ptr, len) != 0)
Bryce> return;
Bryce> +
Bryce> + char* strerr = strerror (errno);
Bryce> + throw new java::io::IOException (JvNewStringUTF (strerr));
I think this hunk is wrong.
`setsockopt' returns 0 if it succeeds.
Tom