This is the mail archive of the java-patches@sources.redhat.com mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: ZipFile/JarFile OPEN_DELETE mode


Hi,

On Sun, Aug 27, 2000 at 03:01:18PM -0700, Anthony Green wrote:
> 
> Mark - I think you should feel free to commit changes to files for which you 
> are the original author.
OK. Thanks.

> As for the ZipFile change, there's just one nit about coding style a 
> braces...
> 
> We've been putting braces on new lines.  While the coding style across the 
> original libgcj and classpath code is not consistent, we should at least try 
> to keep each file internally consistent.  Other than that, it looks fine to 
> me.

Ah, yes. And the file also used tabs of width 8 for indentation (yuck).
I have corrected the braces and the indentation and committed.

Cheers,

Mark

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]