This is the mail archive of the
java-patches@sources.redhat.com
mailing list for the Java project.
RE: ZipFile/JarFile OPEN_DELETE mode
- To: "'Mark Wielaard'" <mark at klomp dot org>, "java-patches at sources dot redhat dot com" <java-patches at sources dot redhat dot com>
- Subject: RE: ZipFile/JarFile OPEN_DELETE mode
- From: Anthony Green <green at cygnus dot com>
- Date: Sun, 27 Aug 2000 15:01:18 -0700
- Organization: Red Hat
- Reply-To: "green at cygnus dot com" <green at cygnus dot com>
On Sunday, August 27, 2000 1:46 PM, Mark Wielaard [SMTP:mark@klomp.org]
wrote:
> I made the following patch. OK to commit?
Mark - I think you should feel free to commit changes to files for which you
are the original author.
As for the ZipFile change, there's just one nit about coding style a
braces...
+ if ((mode & OPEN_DELETE) != 0) {
+ delete_on_close = f;
+ // f.deleteOnExit(); XXX - Not yet implemented in libgcj
+ } else {
+ delete_on_close = null;
+ }
We've been putting braces on new lines. While the coding style across the
original libgcj and classpath code is not consistent, we should at least try
to keep each file internally consistent. Other than that, it looks fine to
me.
Thanks!
AG