This is the mail archive of the java-patches@sources.redhat.com mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch: java.io.Printwriter


Hi,

On Wed, Aug 23, 2000 at 04:22:12PM -0600, Tom Tromey wrote:
> Mark> I just checked in the following patch into Classpath.
> Mark> OK to check into libgcj?
> 
> For merged classes I think we should always remain in sync.
> In other words, updates of merged classes are preapproved.
> (Well, provided they aren't exceptional, like breaking the build or
> something.)
OK. Thanks.

> Mark>    public void print(String str)
> Mark>    {
> Mark> -    try
> Mark> -      {
> Mark>  	write(str == null ? "null" : str);
> 
> This line should lose a 4 leading spaces.
It doesn't have any. The original line had a only a tab at the beginning
and I didn't touch it, I only deleted the two lines before and after.
I try to never change the code style of an existing file.

Cheers,

Mark

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]