This is the mail archive of the
java-patches@sources.redhat.com
mailing list for the Java project.
Re: java.util.zip patches
- To: Anthony Green <green at cygnus dot com>
- Subject: Re: java.util.zip patches
- From: 'Mark Wielaard' <mark at klomp dot org>
- Date: Sun, 20 Aug 2000 23:52:22 +0200
- Cc: "java-patches at sources dot redhat dot com" <java-patches at sources dot redhat dot com>
- References: <01C00AB2.C05C3A20.green@cygnus.com>
Hi,
On Sun, Aug 20, 2000 at 02:24:32PM -0700, Anthony Green wrote:
> On Sunday, August 20, 2000 2:10 PM, Mark Wielaard [SMTP:mark@klomp.org]
> wrote:
> > While writing documentation for the java.util.zip classes I made a couple
> > of non documentation changes. Is it ok to check these in?
>
> Yes - they look fine to me.
Done.
> I was surpised by the ZipInputStream.available() change, but when it's
> obviously correct according to the docs. Doesn't it really make
> InputStream.available() meaningless? Bizarre.
The most bizarre thing is that ZipInputStream.available() only has this
behaviour since the real problem is with InflaterInputStream (the superclass
of ZipInputStream). InflaterInputStream extends from FilteredInputStream
and does not override available() so when someone calls available it
is actually called on the original (compressed) InputStream (in) which is
not what you would expect. But for 1.2 Sun decided to keep that behaviour
and only change the behaviour of ZipInputStream.available().
Cheers,
Mark