This is the mail archive of the
java-patches@sourceware.cygnus.com
mailing list for the Java project.
Re: Patch: More __builtin_expect fun
- To: Andrew Haley <aph at pasanda dot cygnus dot co dot uk>
- Subject: Re: Patch: More __builtin_expect fun
- From: Bryce McKinlay <bryce at albatross dot co dot nz>
- Date: Thu, 04 May 2000 17:09:46 +1200
- CC: java-patches at sourceware dot cygnus dot com
- References: <20000501101722.27336.qmail@pasanda.cygnus.co.uk>
Andrew Haley wrote:
> Great. One small nit: as this is C++ code, shouldn't this
>
> if (__builtin_expect (! obj || isPrimitive (), 0))
> return false;
>
> read better as:
>
> if (__builtin_expect (! obj || isPrimitive (), false))
> return false;
Yeah. I used "0" to maintain consistency with the __builtin_expect calls that
Anthony already added. If I change it in my patch, it would make sense to go
back and change all the __builtin_expect calls to use "false". ok?
regards
[ bryce ]