This is the mail archive of the
java-patches@sourceware.cygnus.com
mailing list for the Java project.
Patch: java.math.BigInteger
- To: java-patches at sourceware dot cygnus dot com
- Subject: Patch: java.math.BigInteger
- From: Warren Levy <warrenl at cygnus dot com>
- Date: Fri, 24 Mar 2000 01:18:29 -0800 (PST)
A couple patches to fix problems identified by Hans Boehm.
--warrenl
2000-03-24 Warren Levy <warrenl@cygnus.com>
* java/math/BigInteger.java(divide): Handle the special case when
dividing by 1 and the high bit of the dividend is set.
(setShiftRight): Handle case when count == 0.
Index: java/math/BigInteger.java
===================================================================
RCS file: /cvs/java/libgcj/libjava/java/math/BigInteger.java,v
retrieving revision 1.6
diff -u -p -r1.6 BigInteger.java
--- BigInteger.java 2000/03/09 04:35:30 1.6
+++ BigInteger.java 2000/03/24 09:14:22
@@ -750,6 +750,12 @@ public class BigInteger extends Number i
else if (ylen == 1)
{
qlen = xlen;
+ // Need to leave room for a word of leading zeros if dividing by 1
+ // and the dividend has the high bit set. It might be safe to
+ // increment qlen in all cases, but it certainly is only necessary
+ // in the following case.
+ if (ywords[0] == 1 && xwords[xlen-1] < 0)
+ qlen++;
rlen = 1;
ywords[0] = MPN.divmod_1(xwords, xwords, xlen, ywords[0]);
}
@@ -770,7 +776,7 @@ public class BigInteger extends Number i
// significant word.
int x_high = MPN.lshift(xwords, 0, xwords, xlen, nshift);
xwords[xlen++] = x_high;
- }
+ }
if (xlen == ylen)
xwords[xlen++] = 0;
@@ -1381,7 +1387,10 @@ public class BigInteger extends Number i
{
if (words == null || words.length < d_len)
realloc(d_len);
- MPN.rshift(words, x.words, word_count, d_len, count);
+ if (count == 0)
+ System.arraycopy(x.words, word_count, words, 0, d_len);
+ else
+ MPN.rshift(words, x.words, word_count, d_len, count);
ival = d_len;
if (neg)
words[ival-1] |= -1 << (32 - count);