This is the mail archive of the
mailing list for the GCC project.
Re: Who broke options.h?
On Tue, Apr 25, 2017 at 06:58:56PM +0200, Jakub Jelinek wrote:
> On Tue, Apr 25, 2017 at 09:54:04AM -0700, Steve Kargl wrote:
> > On Tue, Apr 25, 2017 at 05:46:15PM +0200, Andreas Schwab wrote:
> > > On Apr 25 2017, Steve Kargl <email@example.com> wrote:
> > >
> > > > Someone (other than Richard who seems to have fixed his
> > > > bootstrap issue) in the last 3 days has broken bootstrap
> > > > on FreeBSD.
> > >
> > > Did you change your locale since then?
> > >
> > See my reply to Joseph. It is locale related. I'm surprised
> > I haven't seen this before, which suggests that I must always
> > login into my normal account and then su to the gcc/ account.
> So like (to follow how we set env vars in other spots):
> * Makefile.in (s-options): Call opt-gather.awk with
> LC_ALL=C in the environment.
> --- gcc/Makefile.in 2017-04-18 21:16:24.703775156 +0200
> +++ gcc/Makefile.in 2017-04-25 18:56:58.304963926 +0200
> @@ -2139,6 +2139,7 @@ s-specs : Makefile
> optionlist: s-options ; @true
> s-options: $(ALL_OPT_FILES) Makefile $(srcdir)/opt-gather.awk
> + LC_ALL=C ; export LC_ALL ; \
> $(AWK) -f $(srcdir)/opt-gather.awk $(ALL_OPT_FILES) > tmp-optionlist
> $(SHELL) $(srcdir)/../move-if-change tmp-optionlist optionlist
> $(STAMP) s-options
> ? Untested.
This appears to fix my problem. Do you want to commit the patch
or would you rather have me do it? Note, the problem is present
in 7-branch. I haven't checked the other branches.