This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: -fsanitize=thread support on ppc64


> On Jan 23, 2017, at 8:47 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> 
> On Mon, Jan 23, 2017 at 08:45:16AM -0600, Bill Schmidt wrote:
>>> 2017-01-23  Jakub Jelinek  <jakub@redhat.com>
>>> 
>>> 	* configure.tgt: Enable tsan and lsan on powerpc64{,le}-*-linux*.
>>> 
>>> --- libsanitizer/configure.tgt.jj	2016-11-09 15:22:50.000000000 +0100
>>> +++ libsanitizer/configure.tgt	2017-01-23 15:25:21.059399613 +0100
>>> @@ -1,5 +1,5 @@
>>> # -*- shell-script -*-
>>> -#   Copyright (C) 2012 Free Software Foundation, Inc.
>>> +#   Copyright (C) 2012-2017 Free Software Foundation, Inc.
>>> 
>>> # This program is free software; you can redistribute it and/or modify
>>> # it under the terms of the GNU General Public License as published by
>>> @@ -31,6 +31,11 @@ case "${target}" in
>>> 	fi
>>> 	;;
>>>  powerpc*-*-linux*)
>> 
>> I think you want a separate entry for powerpc64*-*-linux* -- IIRC, the 
>> existing code will definitely not work for 32-bit due to TLS differences.
>> Thus be sure we don't enable TSAN for powerpc-*-linux.
> 
> That is handled by the
> 
>>> +	if test x$ac_cv_sizeof_void_p = x8; then
> 
> test (similarly how for both i?86-*-linux* and x86_64-*-linux* it is enabled
> only for LP64 multilib and not others).  We want to enable it only for the
> 64-bit multilib, not 32-bit.

Ah, quite right.  Sorry for the sloppy reading.

Bill

> 
>>> +		TSAN_SUPPORTED=yes
>>> +		LSAN_SUPPORTED=yes
>>> +		TSAN_TARGET_DEPENDENT_OBJECTS=tsan_rtl_ppc64.lo
>>> +	fi
>>> 	;;
>>>  sparc*-*-linux*)
>>> 	;;
> 
> 	Jakub
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]