This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: style convention: /*foo_p=*/ to annotate bool arguments


On 10/11/2016 11:24 AM, Jason Merrill wrote:
On Tue, Oct 11, 2016 at 10:54 AM, Martin Sebor <msebor@gmail.com> wrote:
To close the loop on this thread, although there was mild support
for both of these conventions there were also objections to both,
including a suggestion for an alternative to the "/*foo_p=*/" style
that would be preferred by most people who responded.

With that I don't have the sense that there is consensus to adopt
either style as conventions for GCC code.

Jason and Jeff (and other reviewers), what does this mean for those
of us submitting patches?  Do we discontinue using the "/*foo_p=*/"
style in the C++ front end or should we train ourselves to remember
to use it there but nowhere else?

I still like the comments when it's not clear what the arguments mean
without looking at the callee, no matter the type of the argument.  I
would be happy with a patch that changed some of the booleans to enums
instead.
Then let's go with this as the desired direction.

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]