This is the mail archive of the
mailing list for the GCC project.
Re: [GCC Steering Committee attention] [PING] [PING] [PING] libgomp: In OpenACC testing, cycle though $offload_targets, and by default only build for the offload target that we're actually going to test
- From: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- Cc: Thomas Schwinge <thomas at codesourcery dot com>, Jakub Jelinek <jakub at redhat dot com>, gcc mailing list <gcc at gcc dot gnu dot org>, David Edelsohn <edelsohn at gnu dot org>
- Date: Fri, 5 Aug 2016 13:06:01 +0100
- Subject: Re: [GCC Steering Committee attention] [PING] [PING] [PING] libgomp: In OpenACC testing, cycle though $offload_targets, and by default only build for the offload target that we're actually going to test
- Authentication-results: sourceware.org; auth=none
- References: <email@example.com> <firstname.lastname@example.org> <email@example.com> <firstname.lastname@example.org> <email@example.com> <CAO9iq9Gy90TM_Uj702ye82+TKAgnWrngtYsKDzcEwU6Mio=QAg@mail.gmail.com>
On 5 August 2016 at 12:16, Janne Blomqvist <firstname.lastname@example.org> wrote:
> - a "2-week rule"; if a patch by a reviewer goes unreviewed for 2
> weeks, the reviewer can commit it without review. A bit like your
> option a).
> The 2-week rule, in particular, came about due to frustration with
> lack of reviews.
Two weeks perhaps is too short, given the lack of reviewers and
understanding that they may be offline, on holidays or some other
issue. But 4 pings without any kind of response would be reasonable,
IMHO. And revert swiftly in case of problems.