This is the mail archive of the
mailing list for the GCC project.
Re: GCC testsuite maintenance (was: [PATCH] Fix OpenACC vector_length parsing in fortran)
- From: Mike Stump <mikestump at comcast dot net>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, Jakub Jelinek <jakub at redhat dot com>, GCC Development <gcc at gcc dot gnu dot org>, Cesar Philippidis <cesar at codesourcery dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Fortran List <fortran at gcc dot gnu dot org>
- Date: Mon, 25 Jul 2016 11:09:26 -0700
- Subject: Re: GCC testsuite maintenance (was: [PATCH] Fix OpenACC vector_length parsing in fortran)
- Authentication-results: sourceware.org; auth=none
- References: <email@example.com> <firstname.lastname@example.org> <20160715082113.GR7387@tucnak.redhat.com> <email@example.com> <alpine.DEB.firstname.lastname@example.org>
On Jul 25, 2016, at 9:37 AM, Joseph Myers <email@example.com> wrote:
> On Fri, 15 Jul 2016, Thomas Schwinge wrote:
>>> No, we want to have as little churn as possible in existing tests, the
>>> general policy is to add new tests (not just for OpenACC/OpenMP, but for
>>> all functionality).
>> Hmm, that's something I had not been aware of, and I can't find this
>> covered in the documentation. So, you're basically saying that files in
>> the testsuite are write-once, and should not be maintained aside from
>> fixing errors, adjusting due to optimization changes, or due to changed
>> diagnostics, and the like? (Of course, I do agree that we shouldn't
> Yes, that's my view. It makes it easier to distinguish regressions from
> new tests that fail (on some platforms) if what a test tests doesn't
> change unnecessarily.
Right. Roughly the test suite is a monotonic, slow moving ever increasing mass. Generally we favor new files for new tests and little to no recoding or rearrangement of existing stuff. We do some limited forms for maintenance, for example, intptr_t to make a less portable test case, to be more portable, just to pick a random recent edit; but these tend to be very minor and very narrowly focused.