This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: GCC testsuite maintenance (was: [PATCH] Fix OpenACC vector_length parsing in fortran)


On Jul 25, 2016, at 9:37 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> 
> On Fri, 15 Jul 2016, Thomas Schwinge wrote:
> 
>>> No, we want to have as little churn as possible in existing tests, the
>>> general policy is to add new tests (not just for OpenACC/OpenMP, but for
>>> all functionality).
>> 
>> Hmm, that's something I had not been aware of, and I can't find this
>> covered in the documentation.  So, you're basically saying that files in
>> the testsuite are write-once, and should not be maintained aside from
>> fixing errors, adjusting due to optimization changes, or due to changed
>> diagnostics, and the like?  (Of course, I do agree that we shouldn't
> 
> Yes, that's my view.  It makes it easier to distinguish regressions from 
> new tests that fail (on some platforms) if what a test tests doesn't 
> change unnecessarily.

Right.  Roughly the test suite is a monotonic, slow moving ever increasing mass.  Generally we favor new files for new tests and little to no recoding or rearrangement of existing stuff.  We do some limited forms for maintenance, for example, intptr_t to make a less portable test case, to be more portable, just to pick a random recent edit; but these tend to be very minor and very narrowly focused.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]