This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Shouldn't convert_scalars_to_vector call free_dominance_info?


On Thu, Mar 10, 2016 at 1:48 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> convert_scalars_to_vector in i386.c calls
>
> calculate_dominance_info (CDI_DOMINATORS);
>
> Shouldn't it call
>
> free_dominance_info (CDI_DOMINATORS);
>
> after it is done like other places where calculate_dominance_info is used?

Only if it invalidates it.   Other than post-dominator info dominator
info is kept
up-to-date between passes.

> When I extend the STV pass to 64-bit and put the 64-bit STV pass before
> the CSE pass, I run into
>
> gcc_assert (!dom_info_available_p (CDI_DOMINATORS));

That looks like a bogus assert to me.  Which one is it?  The one in
cfgcleanup.c?
In that case something else should have freed it (the thing that
doesn't preserve it)
or the condition the assert is guarded is "incorrect".

Richard.

>
> --
> H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]