This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: How do we write unused arguments?
- From: Marek Polacek <polacek at redhat dot com>
- To: Bernd Schmidt <bschmidt at redhat dot com>
- Cc: gcc at gcc dot gnu dot org
- Date: Thu, 5 Nov 2015 11:45:24 +0100
- Subject: Re: How do we write unused arguments?
- Authentication-results: sourceware.org; auth=none
- References: <563B221B dot 9070806 at redhat dot com>
On Thu, Nov 05, 2015 at 10:32:11AM +0100, Bernd Schmidt wrote:
> When reviewing patches I'm never quite sure which of the following we should
> be using:
>
> some_target_hook (tree decl, machine_mode mode ATTRIBUTE_UNUSED)
>
> some_target_hook (tree decl, machine_mode ARG_UNUSED (mode))
>
> some_target_hook (tree decl, machine_mode /* mode */)
>
> some_target_hook (tree decl, machine_mode)
>
> Any opinions? I'm leaning towards the last version since it's idiomatic in
> the language we're using and has the least amount of visual clutter. If no
> one comments, I'll start enforcing that in patch reviews. Currently no one
> seems sure and everything is getting totally inconsistent.
FWIW, I also like the last version best.
Marek