This is the mail archive of the
mailing list for the GCC project.
Re: [RFC] Kernel livepatching support in GCC
- From: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- To: Maxim Kuvyrkov <maxim dot kuvyrkov at linaro dot org>, Richard Guenther <richard dot guenther at gmail dot com>
- Cc: GCC Development <gcc at gcc dot gnu dot org>, Li Bin <huawei dot libin at huawei dot com>, Andi Kleen <ak at linux dot intel dot com>, Takahiro Akashi <takahiro dot akashi at linaro dot org>
- Date: Thu, 28 May 2015 17:37:53 +0200
- Subject: Re: [RFC] Kernel livepatching support in GCC
- Authentication-results: sourceware.org; auth=none
- References: <844CBBAF-DA0E-4164-9E35-34075A26F665 at linaro dot org> <CEDC3659-14B8-42A4-9ED8-485EC62B615C at gmail dot com> <535E656D-9CA2-4506-8918-CD73C0F63F84 at linaro dot org>
On 05/28/2015 11:16 AM, Maxim Kuvyrkov wrote:
>> On May 28, 2015, at 11:59 AM, Richard Biener <firstname.lastname@example.org> wrote:
>> Maybe follow s390 -mhotpatch instead?
> Regarding implementation of the option, it will follow what s390 is doing with function attributes to mark which functions to apply nop-treatment to (using attributes will avoid problems with [coming] LTO builds of the kernel). The new option will set value of the attribute on all functions in current compilation unit, and then nops will be generated from the attribute specification.
> On the other hand, s390 does not generate a section of descriptor entries of NOP pads, which seems like a useful (or necessary) option. A more-or-less generic implementation should, therefore, combine s390's attributes approach to annotating functions and x86's approach to providing information in an ELF section about NOP entries. Or can we record value of a function attribute in ELF in a generic way?
I agree that would be useful. The only reason we didn't implement that was that our kernel guys were
confident enough to be able to detect patchable functions without it. We discussed two solutions to
1. Add special relocations pointing to the patchable areas.
2. Add a special section listing all patchable areas. I think systemtap is doing something similiar
for their probes.
> Whatever the specifics, implementation of livepatch support should be decoupled from -pg/mcount dependency as I don't see any real need in overloading mcount with livepatching stuff.
For user space hotpatching we also needed hotpatching areas *before* the function label to emit
trampolines there. This perhaps should be covered by a generic approach as well.