This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] RE: gcc parallel make check


On Fri, Sep 05, 2014 at 02:26:45PM +0000, VandeVondele  Joost wrote:
> Adding label:  mu matching files:278
> Adding label:  wlgo matching files:284
> Adding label:  vhzPkqWx_-9876543210ZYXVUTSRQONMLKJIHGFEDCBAyj matching files:94
> patterns:
> dg.exp=gfortran.dg/p* \
> dg.exp=gfortran.dg/c* \
> dg.exp=gfortran.dg/a* \
> dg.exp=gfortran.dg/i* \
> dg.exp=gfortran.dg/\[wlgo\]* \
> dg.exp=gfortran.dg/\[mu\]* \
> dg.exp=gfortran.dg/d* \
> dg.exp=gfortran.dg/s* \
> dg.exp=gfortran.dg/b* \
> dg.exp=gfortran.dg/t* \
> dg.exp=gfortran.dg/f* \
> dg.exp=gfortran.dg/e* \
> dg.exp=gfortran.dg/r* \
> dg.exp=gfortran.dg/n* \
> dg.exp=gfortran.dg/\[vhzPkqWx_-9876543210ZYXVUTSRQONMLKJIHGFEDCBAyj\]* \
> 
> Is the current attached patch OK for trunk ?

> gcc/fortran/ChangeLog
> 
>  2014-09-05  Joost VandeVondele  <vondele@gcc.gnu.org>
> 
>        * Make-lang.in (check_gfortran_parallelize): improved parallelism.

Capital I.

> --- gcc/fortran/Make-lang.in	(revision 214949)
> +++ gcc/fortran/Make-lang.in	(working copy)
> @@ -168,12 +168,22 @@ check-fortran-subtargets : check-gfortra
>  lang_checks += check-gfortran
>  lang_checks_parallelized += check-gfortran
>  # For description see comment above check_gcc_parallelize in gcc/Makefile.in.
> -check_gfortran_parallelize = dg.exp=gfortran.dg/\[adAD\]* \
> -			     dg.exp=gfortran.dg/\[bcBC\]* \
> -			     dg.exp=gfortran.dg/\[nopNOP\]* \
> -			     dg.exp=gfortran.dg/\[isuvISUV\]* \
> -			     dg.exp=gfortran.dg/\[efhkqrxzEFHKQRXZ\]* \
> -			     dg.exp=gfortran.dg/\[0-9gjlmtwyGJLMTWY\]*
> +check_gfortran_parallelize = execute.exp \
> +			dg.exp=gfortran.dg/p* \
> +			dg.exp=gfortran.dg/c* \
> +			dg.exp=gfortran.dg/a* \
> +			dg.exp=gfortran.dg/i* \
> +			dg.exp=gfortran.dg/\[wlgo\]* \
> +			dg.exp=gfortran.dg/\[mu\]* \
> +			dg.exp=gfortran.dg/d* \
> +			dg.exp=gfortran.dg/s* \
> +			dg.exp=gfortran.dg/b* \
> +			dg.exp=gfortran.dg/t* \
> +			dg.exp=gfortran.dg/f* \
> +			dg.exp=gfortran.dg/e* \
> +			dg.exp=gfortran.dg/r* \
> +			dg.exp=gfortran.dg/n* \
> +			dg.exp=gfortran.dg/\[vhzPkqWx_-9876543210ZYXVUTSRQONMLKJIHGFEDCBAyj\]*

Please sort the letters (LC_ALL=C sort) and where consecutive, use ranges.
Thus \[0-9A-Zhjqvx-z\]* or so.  What is - doing in your list?  _-9 is quite
unexpected range.  Also, please tweak the script so that it will do the
sorting and ranges handling for you.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]