This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Enable EBX for x86 in 32bits PIC code
- From: Ilya Enkovich <enkovich dot gnu at gmail dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: Jeff Law <law at redhat dot com>, Vladimir Makarov <vmakarov at redhat dot com>, gcc at gnu dot org, gcc-patches <gcc-patches at gcc dot gnu dot org>, Evgeny Stupachenko <evstupac at gmail dot com>, Richard Biener <richard dot guenther at gmail dot com>
- Date: Thu, 28 Aug 2014 16:54:43 +0400
- Subject: Re: Enable EBX for x86 in 32bits PIC code
- Authentication-results: sourceware.org; auth=none
- References: <CAOvf_xxsQ_oYGqNAVQ1+BW+CuD3mzebZ2xma0jpF=WfyZMCRCA at mail dot gmail dot com> <CAFiYyc1mFtTezkTJORmJJq+yht=qPSwiN7KDn19+bSuSdaqvMQ at mail dot gmail dot com> <CAOvf_xyeVeg2oB9Xxz8RMEQ6gyfJY5whd9s4ygoAAEaMU9efnA at mail dot gmail dot com> <20140707114750 dot GB31640 at tucnak dot redhat dot com> <CAMbmDYZV_fx0jxmKHhLsC2pJ7pDzuu6toEAH72izOdpq6KGyfg at mail dot gmail dot com> <20140822121151 dot GA60032 at msticlxl57 dot ims dot intel dot com> <53FB5184 dot 3030500 at redhat dot com> <CAMbmDYbP77pmkqpJD8cnXbe7_8aRMnYF-tnfKRubULn8-aDCdw at mail dot gmail dot com> <CAMbmDYacBWjKtCYPB0A2m=fkUTk_Wt5D6f2aEkH7C3paWaR7ag at mail dot gmail dot com> <53FCA6F5 dot 7020405 at redhat dot com> <20140826213712 dot GA39451 at msticlxl57 dot ims dot intel dot com> <53FE5002 dot 6040005 at redhat dot com> <CAMbmDYbTA+=tqZO0g2OR8oWqEaUfzm8eAh+anNszKqO1z62P2Q at mail dot gmail dot com> <CAFULd4bMH6Rt=DvA7j6ZLgbt3BL8xL_xnLTWRGgjS9CYSW-8WQ at mail dot gmail dot com>
2014-08-28 16:42 GMT+04:00 Uros Bizjak <ubizjak@gmail.com>:
> On Thu, Aug 28, 2014 at 10:37 AM, Ilya Enkovich <enkovich.gnu@gmail.com> wrote:
>> 2014-08-28 1:39 GMT+04:00 Jeff Law <law@redhat.com>:
>>> On 08/26/14 15:42, Ilya Enkovich wrote:
>>>>
>>>> diff --git a/gcc/calls.c b/gcc/calls.c
>>>> index 4285ec1..85dae6b 100644
>>>> --- a/gcc/calls.c
>>>> +++ b/gcc/calls.c
>>>> @@ -1122,6 +1122,14 @@ initialize_argument_information (int num_actuals
>>>> ATTRIBUTE_UNUSED,
>>>> call_expr_arg_iterator iter;
>>>> tree arg;
>>>>
>>>> + if (targetm.calls.implicit_pic_arg (fndecl ? fndecl : fntype))
>>>> + {
>>>> + gcc_assert (pic_offset_table_rtx);
>>>> + args[j].tree_value = make_tree (ptr_type_node,
>>>> + pic_offset_table_rtx);
>>>> + j--;
>>>> + }
>>>> +
>>>> if (struct_value_addr_value)
>>>> {
>>>> args[j].tree_value = struct_value_addr_value;
>>>
>>> So why do you need this? Can't this be handled in the call/call_value
>>> expanders or what about attaching the use to CALL_INSN_FUNCTION_USAGE from
>>> inside ix86_expand_call? Basically I'm not seeing the need for another
>>> target hook here. I think that would significantly simply the patch as
>>> well.
>>
>> GOT base address become an additional implicit arg with EBX relaxed
>> and I handled it as all other args. I can move EBX initialization into
>> ix86_expand_call. Would still need some hint from target to init
>> pic_offset_table_rtx with proper value in the beginning of function
>> expand.
>
> Maybe you can you use get_hard_reg_initial_val for this?
Actually there is no input hard reg holding GOT address. Currently I
use initialization with ebx with following ebx initialization in
prolog_epilog pass. But this is a temporary workaround. It is
inefficient because always uses callee save reg to get GOT address. I
suppose we should generate pseudo reg for pic_offset_table_rtx and
also set_got with this register as a destination in expand pass.
After register allocation set_got may be transformed into get_pc_thunk
call with proper hard reg. But some target hook has to be used for
this.
Ilya
>
> Uros.