This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [GSoC] generation from isl_ast_node_user


>You may want to take a look at polly commit r212186, where I reworked
>and documented how this works.

It is much easier for understanding. Thank you! I've tried to consider
an older version.

>Is this necessary? The id should already be set in
>(graphite-sese-to-poly.c):
>
>static isl_id *
>isl_id_for_pbb (scop_p s, poly_bb_p pbb)
>{
>  char name[50];
>  snprintf (name, sizeof (name), "S_%d", pbb_index (pbb));
>  return isl_id_alloc (s->ctx, name, pbb);
>
>}

Thank you! I haven't known about this function. Should its declaration
be moved to graphite-sese-to-poly.h or it is better to redefine it in
the graphite-isl-ast-to-gimple.c?

>Perfect! (or at least that's the same approach I have choosen for Polly)
>
>Do you have any problems with this approach? From my perspective it
>looks like a good solution.

No, I don't (at least for now).

--
                                   Cheers, Roman Gareev


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]