This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Incorrect generated code for conditional
- From: Arthur Schwarz <aschwarz1309 at att dot net>
- To: "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>
- Date: Sun, 16 Mar 2014 09:20:16 -0700 (PDT)
- Subject: Incorrect generated code for conditional
- Authentication-results: sourceware.org; auth=none
- Reply-to: Arthur Schwarz <aschwarz1309 at att dot net>
Win7 - 64bit
gcc (GCC) 4.8.2
g++ -w -DYYDEBUG=1 -DDEBUG_IO -c -g -MMD -MP -MF "build/Debug/Cygwin-Windows/SlipRegister.o.d" -o build/Debug/Cygwin-Windows/SlipRegister.o SlipRegister.cpp
There is no generated code for "retval = true;" in the conditional block. I am including the code fragment and disassembled code.
If the issue seems to be a bug then I will include whatever additional data is required to help gcc identify the error. If it is not a bug then I truly apologize for wasting your time.
What happens is that the conditional is executed but there is no required code.
art
--------------------- source code ----------------------
bool SlipRegister::post(const string& name, SlipHeader& head) {
bool retval = false;
if (!head.isHeader()) {
postError(SlipErr::E4002, "SlipRegister::post", "", "", head);
} else { // attempt to insert a new entry
SlipAsciiEntry entry(name, &head, SlipHashEntry::DEFINED);
SlipHash::ReturnTuple tuple = hashTable->insert(entry);
if (tuple.condition == SlipHash::ReturnTuple::INSERTED) {
retval == true; // skipped over
} else if (tuple.condition == SlipHash::ReturnTuple::FOUND) {
if (fsm(*tuple.entry, SlipHashEntry::DEFINED)) {
((SlipHeader*)((tuple.entry)->getBinaryKey()))->moveListRight(head);
head.deleteList();
retval = true;
} else if ((tuple.entry)->getType() == SlipHashEntry::USERDATA) {
postError(SlipErr::E4001, "SlipRegister::post", "", "", head);
} else {
postError(SlipErr::E4015, "SlipRegister::post", "", "", head);
};
}
}
DEBUG(debugFlag,
cout << sFlag[retval] << "post(" << name << ", " << head.toString()
<< ") " << endl;)
return retval;
}; // bool SlipRegister::post(const string& name, SlipHeader& head, bool defineFlag)
--------------- disassembled code fragment ------------
! SlipHash::ReturnTuple tuple = hashTable->insert(entry);
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+337: mov 0xb0(%rbp),%rax
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+344: mov (%rax),%rdx
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+347: lea -0x20(%rbp),%rax
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+351: lea -0x50(%rbp),%rcx
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+355: mov %rcx,%r8
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+358: mov %rax,%rcx
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+361: callq 0x10042d316 <slip::SlipHash::insert(slip::SlipHashEntry&)>
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+987: lea -0x20(%rbp),%rax
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+991: mov %rax,%rcx
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+994: callq 0x1004e6c60 <slip::SlipHash::ReturnTuple::~ReturnTuple()>
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+1509: lea -0x20(%rbp),%rax
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+1513: mov %rax,%rcx
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+1516: callq 0x1004e6c60 <slip::SlipHash::ReturnTuple::~ReturnTuple()>
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+1521: jmp 0x10045c4e4 <slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+1526>
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+1523: mov %rax,%rbx
! if (tuple.condition == SlipHash::ReturnTuple::INSERTED) {
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+366: mov -0x14(%rbp),%eax
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+369: cmp $0x4,%eax
slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+372: je 0x10045c2c9 <slip::SlipRegister::post(std::string const&, slip::SlipHeader&)+987>
! retval == true;
! } else if (tuple.condition == SlipHash::ReturnTuple::FOUND) {