This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: Building GCC with -Wmissing-declarations and addressing its warnings
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Patrick Palka <patrick at parcs dot ath dot cx>
- Cc: "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>
- Date: Thu, 20 Feb 2014 18:21:30 +0000
- Subject: Re: Building GCC with -Wmissing-declarations and addressing its warnings
- Authentication-results: sourceware.org; auth=none
- References: <CA+C-WL_H_vgr5RvqkKg-esidYsfPEQTRM3zniLDc+8OvXVb2nA at mail dot gmail dot com> <CAH6eHdSfMF=yjp988wk36U2Pmcob75wLqjWM2Su9mRaAKnJLXQ at mail dot gmail dot com> <CA+C-WL82Ch3iVTuu4+FP6ikaNds3At=i7MLT5=D59zMfe=8J5Q at mail dot gmail dot com> <CAH6eHdQX9HTr6uxvD3Tc2_Ntec1OygZSjuZ14DdMcb=CVzXwTw at mail dot gmail dot com> <CA+C-WL-iEu=GHp8nZ=z1bSQpX+E4mSFRqqz+13AmqmL4jHAaRQ at mail dot gmail dot com> <CAH6eHdQRj2BgG5HLVesXwYCcU0eydb3aJW_KT2UwLEcegwDC0g at mail dot gmail dot com> <CA+C-WL966gncos_tZNNqE8SPnEsU0Gm0wznXSuBW5a1r7si4YA at mail dot gmail dot com>
On 20 February 2014 18:16, Patrick Palka wrote:
> On Thu, Feb 20, 2014 at 1:14 PM, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
>> On 20 February 2014 15:31, Patrick Palka wrote:
>>> (I counted nearly 100 (non-debug)
>>> functions that could be made static in gcc, and 4 in libstdc++, by the
>>> way.)
>>
>> Which were the four in libstdc++?
>>
>> I only see __gslice_on_index and __concat_size_t.
>
> Those two along with _Rb_tree_rotate_left and _Rb_tree_rotate_right.
See the comments above those functions. (That mistake shouldn't
happen again, because we have the check-abi test to catch it.)