This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase
- From: Senthil Kumar Selvaraj <senthil_kumar dot selvaraj at atmel dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: Mike Stump <mikestump at comcast dot net>, "gcc at gcc dot gnu dot org List" <gcc at gcc dot gnu dot org>, "dodji at redhat dot com Seketeli" <dodji at redhat dot com>, "janisjo at codesourcery dot com Johnson" <janisjo at codesourcery dot com>
- Date: Wed, 3 Apr 2013 00:55:18 +0530
- Subject: Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase
- References: <20130327080214 dot GA7422 at atmel dot com> <57AC2D0F-7AB7-46A0-BA38-6BC66B876838 at comcast dot net> <20130328105752 dot GA887 at atmel dot com> <74DC064C-48E4-4462-A3EB-645F263A7FD4 at comcast dot net> <5155E199 dot 6070603 at redhat dot com> <20130330062307 dot GA13331 at atmel dot com> <515A37AA dot 1050702 at redhat dot com> <F1D390C2-2D95-48F2-AFB5-210F895FD80F at comcast dot net> <20130402130743 dot GA20532 at atmel dot com> <515AF498 dot 7000107 at redhat dot com>
On Tue, Apr 02, 2013 at 11:09:12AM -0400, Jason Merrill wrote:
> On 04/02/2013 09:07 AM, Senthil Kumar Selvaraj wrote:
> >Ok, how about the following (tentative) patch? If -gdwarf- is
> >specified without any argument, it picks DWARF 4 as the default.
>
> -gdwarf- looks a bit odd to me; I was thinking -gdwarf without the
> trailing -.
Does the below patch look good?
Regards
Senthil
diff --git gcc/common.opt gcc/common.opt
index bdbd3b6..5af41d9 100644
--- gcc/common.opt
+++ gcc/common.opt
@@ -2306,8 +2306,12 @@ gcoff
Common JoinedOrMissing Negative(gdwarf-)
Generate debug information in COFF format
+gdwarf
+Common UInteger Var(dwarf_default_version, 4) Negative(gdwarf-)
+Generate debug information in the default DWARF version format
+
gdwarf-
-Common Joined UInteger Var(dwarf_version) Init(4) Negative(gstabs)
+Common Joined UInteger Var(dwarf_version) Init(4) Negative(gstabs) Negative(gdwarf)
Generate debug information in DWARF v2 (or later) format
ggdb
diff --git gcc/opts.c gcc/opts.c
index 45b12fe..c6823a6 100644
--- gcc/opts.c
+++ gcc/opts.c
@@ -1698,7 +1698,9 @@ common_handle_option (struct gcc_options *opts,
case OPT_gcoff:
set_debug_level (SDB_DEBUG, false, arg, opts, opts_set, loc);
break;
-
+
+ case OPT_gdwarf:
+ value = opts->x_dwarf_default_version;
case OPT_gdwarf_:
if (value < 2 || value > 4)
error_at (loc, "dwarf version %d is not supported", value);