This is the mail archive of the
gcc@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase
- From: Mike Stump <mikestump at comcast dot net>
- To: Senthil Kumar Selvaraj <senthil_kumar dot selvaraj at atmel dot com>
- Cc: Mike Stump <mikestump at comcast dot net>, "gcc at gcc dot gnu dot org List" <gcc at gcc dot gnu dot org>, "dodji at redhat dot com Seketeli" <dodji at redhat dot com>, "janisjo at codesourcery dot com Johnson" <janisjo at codesourcery dot com>, Jason Merrill <jason at redhat dot com>
- Date: Thu, 28 Mar 2013 15:09:41 -0700
- Subject: Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase
- References: <20130327080214 dot GA7422 at atmel dot com> <57AC2D0F-7AB7-46A0-BA38-6BC66B876838 at comcast dot net> <20130328105752 dot GA887 at atmel dot com>
On Mar 28, 2013, at 3:57 AM, Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com> wrote:
> On Wed, Mar 27, 2013 at 08:43:53AM -0700, Mike Stump wrote:
>> On Mar 27, 2013, at 1:02 AM, Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com> wrote:
>>> global-used-types.c in gcc/testsuite/gcc.dg/debug/dwarf2 only specifies
>>> -g in dg-options. For a target that is not configured to generate
>>> dwarf-2 by default, the test fails looking for specific DWARF strings in
>>> the generated assembly.
>>>
>>> The patch below changes dg-options to -gdwarf-2. Can someone
>>> apply if it is ok?
>>
>> Ok. [ that clears the way for application. ]
>
> I found a bunch of other testcases missing -gdwarf-2, attached is a
> patch that includes fixes for them as well. Finding these many testcases
> with just -g makes me a bit suspicious though, could there be a reason why
> -gdwarf-2 is not specified?
Hum… I can't help but wonder if there was supposed to be code that checks to ensure dwarf is supported and the default before doing the entire test suite. Let's let a dwarf person chime in. Otherwise, I'd have to go dig into the driver to see if it has the code to limit it.