Re: Gcc-4.8 (20130217) dealing with bugfixes in isl

[Richard Biener <richard dot guenther at gmail dot com>]

On Tue, Mar 5, 2013 at 8:04 PM, koala01 <koala01@free.fr> wrote:
> Hello,
>
> I'm trying to compile the gcc-4.8.0-20130217 snapshot with (eg) the last
> version of isl.
>
> This version has a bug fix which make that isl_version() returns
> "isl-1.11.1", as result that configure script fails to detect isl because it
> try to compile a code like
> int
> main ()
> {
> printf("%s",isl_version());
> if (strncmp (isl_version (), "isl-0.11", strlen ("isl-0.11")) != 0 &&)
>      return 1;
>
>   ;
>   return 0;
> }
>
> of course, this code returns 1 and detection fails.
>
> One possible way to deal with bugfix numbers should to modify the test code
> in something like
> #include <isl/version.h>
>    #include <string.h>
> int
> main ()
> {
> char  *version[8]={};
> strncpy(version, isl_version(),8);
>
> if (strncmp (version, "isl-0.11", strlen ("isl-0.11")) != 0)

Eh?  How should that behave any different?  strncmp compares at most
strlen("isl-0.11") characters which is an equivalent prefix of isl-0.11.1.

The existing test works for me:

configure:5905: checking for version 0.11 of ISL
configure:5924: gcc -o conftest -g -O2      conftest.c  -lisl >&5
configure:5924: $? = 0
configure:5924: ./conftest
configure:5924: $? = 0
configure:5933: result: yes

and I have ISL 0.11.1.

Richard.

>      return 1;
>
>   ;
>   return 0;
> }
> (works if changed directly in configure script)
> What would you thing about idea to integrate such change directly in
> Configure.ac ?
>
> PS: Please excuse my poor english but it isn't my native language