This is the mail archive of the gcc@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Bootstrap broken on rs6000


Committed in r192788.

Thanks,
Sharad
Sharad


On Wed, Oct 24, 2012 at 4:02 PM, Sharad Singhai <singhai@google.com> wrote:
> I thought Steven was going to do that. If not, I can apply it.
>
> Thanks,
> Sharad
> Sharad
>
>
> On Wed, Oct 24, 2012 at 4:00 PM, David Edelsohn <dje.gcc@gmail.com> wrote:
>> Is someone going to apply this patch?
>>
>> Thanks, David
>>
>> On Wed, Oct 24, 2012 at 5:18 PM, Sharad Singhai <singhai@google.com> wrote:
>>> On Wed, Oct 24, 2012 at 2:13 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
>>>> Hello,
>>>>
>>>> ../../trunk/gcc/config/rs6000/rs6000.c: In function 'void
>>>> rs6000_density_test(rs6000_cost_data*)':
>>>> ../../trunk/gcc/config/rs6000/rs6000.c:3550:32: error: 'dump_kind_p'
>>>> was not declared in this scope
>>>>
>>>> This is due to:
>>>>
>>>> 2012-10-24  Sharad Singhai  <singhai at google dot com>
>>>>
>>>>         * dumpfile.c (dump_enabled_p): Make it inline and move the definition
>>>>         to dumpfile.h.
>>>>         (dump_kind_p): Deleted. Functionality replaced by dump_enabled_p.
>>>>         Make alt_dump_file extern.
>>>>         * dumpfile.h (dump_enabled_p): Move inline definition here.
>>>>         (dump_kind_p): Delete declaration.
>>>>         ...
>>>>
>>>> It's kinda nice to check target code as well when changing things... ;-)
>>>
>>> Sorry about that. Will do so in future.
>>>
>>>> Is the change at the bottom of this email correct?
>>>
>>> Yes, that is correct. If there are any more instances of dump_kind_p
>>> (), they should be replaced by dump_enabled_p () as well.
>>>
>>> Thanks,
>>> Sharad
>>>
>>>>
>>>> Ciao!
>>>> Steven
>>>>
>>>>
>>>> Index: config/rs6000/rs6000.c
>>>> ===================================================================
>>>> --- config/rs6000/rs6000.c      (revision 192780)
>>>> +++ config/rs6000/rs6000.c      (working copy)
>>>> @@ -3547,7 +3547,7 @@ rs6000_density_test (rs6000_cost_data *data)
>>>>        && vec_cost + not_vec_cost > DENSITY_SIZE_THRESHOLD)
>>>>      {
>>>>        data->cost[vect_body] = vec_cost * (100 + DENSITY_PENALTY) / 100;
>>>> -      if (dump_kind_p (MSG_NOTE))
>>>> +      if (dump_enabled_p ())
>>>>         dump_printf_loc (MSG_NOTE, vect_location,
>>>>                          "density %d%%, cost %d exceeds threshold, penalizing "
>>>>                          "loop body cost by %d%%", density_pct,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]